Skip to content

Forbid calling readContext() inside useMemo() for SSR #14650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Forbid calling readContext() inside useMemo() for SSR #14650

wants to merge 2 commits into from

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 21, 2019 •
edited
Loading

Based on #14672

Adds the same warning for SSR.

@gaearon gaearon requested a review from threepointone January 21, 2019 19:44
@sizebot
Copy link

sizebot commented Jan 21, 2019 •
edited
Loading

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: f0befae...a392a68

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 738.95 KB 739.18 KB 170.53 KB 170.6 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 98.88 KB 98.88 KB 32.17 KB 32.17 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 101.86 KB 101.86 KB 32.82 KB 32.82 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 734 KB 734.24 KB 169.1 KB 169.16 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 98.88 KB 98.88 KB 31.67 KB 31.67 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 101.98 KB 101.98 KB 32.28 KB 32.29 KB NODE_PROFILING
ReactDOM-dev.js 0.0% +0.1% 756.57 KB 756.88 KB 170.34 KB 170.43 KB FB_WWW_DEV
ReactDOM-prod.js -0.4% -0.2% 312.5 KB 311.38 KB 57.56 KB 57.45 KB FB_WWW_PROD
ReactDOM-profiling.js -0.3% -0.2% 319.66 KB 318.55 KB 58.88 KB 58.79 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 739.29 KB 739.52 KB 170.67 KB 170.74 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 98.89 KB 98.89 KB 32.18 KB 32.18 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 101.88 KB 101.88 KB 32.83 KB 32.83 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 734.35 KB 734.58 KB 169.24 KB 169.31 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 98.9 KB 98.9 KB 31.68 KB 31.68 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 102 KB 102 KB 32.29 KB 32.29 KB NODE_PROFILING
ReactFire-dev.js 0.0% +0.1% 755.78 KB 756.09 KB 170.29 KB 170.38 KB FB_WWW_DEV
ReactFire-prod.js -0.4% -0.1% 301.09 KB 299.98 KB 55.26 KB 55.18 KB FB_WWW_PROD
ReactFire-profiling.js -0.4% -0.2% 308.18 KB 307.07 KB 56.55 KB 56.46 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% 0.0% 44.87 KB 44.87 KB 12.3 KB 12.3 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 9.97 KB 9.97 KB 3.71 KB 3.71 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 44.59 KB 44.59 KB 12.24 KB 12.24 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.61 KB 60.61 KB 15.92 KB 15.92 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 11.01 KB 11.01 KB 3.81 KB 3.81 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.29 KB 60.29 KB 15.79 KB 15.79 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.75 KB 10.75 KB 3.7 KB 3.71 KB NODE_PROD
react-dom-server.browser.development.js +0.6% +0.5% 125.09 KB 125.85 KB 33.35 KB 33.53 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 16.96 KB 16.96 KB 6.53 KB 6.53 KB UMD_PROD
react-dom-server.browser.development.js +0.6% +0.5% 121.22 KB 121.98 KB 32.43 KB 32.6 KB NODE_DEV
ReactDOMServer-dev.js +0.7% +0.6% 122.4 KB 123.23 KB 32.07 KB 32.27 KB FB_WWW_DEV
react-dom-server.node.development.js +0.6% +0.5% 123.28 KB 124.04 KB 32.97 KB 33.14 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 17.74 KB 17.74 KB 6.83 KB 6.83 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.63 KB 3.63 KB 1.44 KB 1.44 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 704 B 706 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.45 KB 3.45 KB 1.39 KB 1.39 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 635 B 637 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.42 KB 1.42 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.1 KB 1.1 KB 665 B 667 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% +0.1% 517.8 KB 518.03 KB 114.37 KB 114.43 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 90.93 KB 90.93 KB 27.96 KB 27.96 KB UMD_PROD
react-art.development.js +0.1% +0.1% 449.31 KB 449.55 KB 97.25 KB 97.32 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 55.91 KB 55.91 KB 17.22 KB 17.22 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 458.29 KB 458.6 KB 96.4 KB 96.49 KB FB_WWW_DEV
ReactART-prod.js -0.6% -0.4% 188.4 KB 187.29 KB 32.23 KB 32.1 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 582.79 KB 583.1 KB 126.96 KB 127.04 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.5% -0.3% 244.14 KB 243.03 KB 42.9 KB 42.79 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.4% -0.2% 250.29 KB 249.18 KB 44.23 KB 44.13 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.1% +0.1% 582.7 KB 583.01 KB 126.92 KB 127 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 227.18 KB 227.18 KB 39.53 KB 39.53 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% -0.0% 233.19 KB 233.19 KB 40.91 KB 40.91 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% +0.1% 573.64 KB 573.95 KB 124.69 KB 124.77 KB RN_FB_DEV
ReactFabric-prod.js -0.5% -0.3% 237.34 KB 236.23 KB 41.44 KB 41.31 KB RN_FB_PROD
ReactFabric-profiling.js -0.5% -0.2% 242.64 KB 241.53 KB 42.76 KB 42.66 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% +0.1% 573.55 KB 573.86 KB 124.64 KB 124.72 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 220.41 KB 220.41 KB 38.07 KB 38.07 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 225.5 KB 225.5 KB 39.45 KB 39.45 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 462.53 KB 462.76 KB 100.01 KB 100.08 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 57.31 KB 57.31 KB 17.6 KB 17.61 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 457.49 KB 457.72 KB 98.78 KB 98.84 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 56.98 KB 56.98 KB 17.45 KB 17.45 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 466.68 KB 466.99 KB 98.27 KB 98.35 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.09 KB 38.09 KB 9.83 KB 9.83 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 10.56 KB 10.56 KB 3.25 KB 3.25 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 32.39 KB 32.39 KB 8.46 KB 8.46 KB NODE_DEV

Generated by 🚫 dangerJS

threepointone
threepointone approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 23, 2019

It's annoying to have so many small ones. I'll send a combined one.

@gaearon gaearon closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@threepointone threepointone threepointone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaearon @sizebot @threepointone @facebook-github-bot